Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH Action Summary #1092

Merged
merged 1 commit into from
Jun 30, 2023
Merged

GH Action Summary #1092

merged 1 commit into from
Jun 30, 2023

Conversation

jayedul
Copy link
Contributor

@jayedul jayedul commented Jun 28, 2023

Description of the Change

GH action summary added for Cypress test report

Closes #991

Changelog Entry

Added - GH action summary added for Cypress test report

Credits

Props @jayedul

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@jayedul jayedul self-assigned this Jun 28, 2023
@jayedul jayedul marked this pull request as ready for review June 28, 2023 07:30
@jayedul jayedul requested review from jeffpaul and a team as code owners June 28, 2023 07:30
@jayedul
Copy link
Contributor Author

jayedul commented Jun 28, 2023

Marked as ready despite one E2E test failed on WP Trunk that seems unrelated to this PR.

@jeffpaul jeffpaul added this to the 2.0.0 milestone Jun 28, 2023
@jeffpaul jeffpaul requested review from peterwilsoncc and removed request for a team and jeffpaul June 28, 2023 13:25
@peterwilsoncc @jayedul
GH Action Summary
1074fde 
Co-authored-by: JK <jayedulk@gmail.com>
@peterwilsoncc
Copy link
Collaborator

Due to conflicts in the package-lock file, I needed to re create this PR and rebase.

gh pr diff 1092 | patch -p1 
git checkout package-lock.json 
rm *.orig
rm *.rej
npm i
git commit ....

peterwilsoncc
peterwilsoncc approved these changes Jun 30, 2023
View reviewed changes
Copy link
Collaborator

@peterwilsoncc peterwilsoncc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@peterwilsoncc peterwilsoncc merged commit ca8b8d3 into develop Jun 30, 2023
@peterwilsoncc peterwilsoncc deleted the update/991 branch June 30, 2023 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterwilsoncc peterwilsoncc peterwilsoncc approved these changes

Assignees

@jayedul jayedul

Labels
None yet
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

Add a GH Actions summary
3 participants
@jayedul @peterwilsoncc @jeffpaul