Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release: 2.0.1 #1136

Merged
merged 6 commits into from
Sep 19, 2023
Merged

Release: 2.0.1 #1136

merged 6 commits into from
Sep 19, 2023

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Sep 14, 2023

  • Branch: Starting from develop, create a release branch named release/X.Y.Z for your changes.
  • Version bump: Bump the version number in distributor.php, package.json, readme.txt and tests/php/bootstrap.php if it does not already reflect the version being released. In distributor.php update both the plugin "Version:" property and the plugin DT_VERSION constant.
  • New files: Ensure any new files, especially in the vendor folder, are correctly included in webpack.config.release.js.
  • Changelog: Add/update the changelog in CHANGELOG.md.
  • Props: Update CREDITS.md file with any new contributors, confirm maintainers are accurate.
  • Readme updates: Make any other readme changes as necessary. README.md is geared toward GitHub and readme.txt contains WordPress.org-specific content. The two are slightly different.
  • Since tag updates: ensure @since tags indicate the new version, replacing x.x.x, n.e.x.t and other placeholders.
  • Merge: Make a non-fast-forward merge from your release branch to develop (or merge the Pull Request), then do the same for develop into trunk (git checkout trunk && git merge --no-ff develop). trunk contains the stable development version.
  • Build: Wait for the Build Stable Release Action to finish running.
  • Update this pull request's status from draft to ready to merge.
  • Review: Do a review of the commit to the stable branch to ensure the contents of the diffs are as expected.
  • Test: Check out the stable branch and test it locally to ensure everything works as expected. It is recommended that you rename the existing distributor directory and check out stable fresh because switching branches does not delete files. This can be done with git clone --single-branch --branch stable git@github.com:10up/distributor.git
  • Release: Create a new release, naming the tag and the release with the new version number, and targeting the stable branch. Paste the changelog from CHANGELOG.md into the body of the release and include a link to the closed issues on the milestone. The release should now appear under releases.
  • Check release: Wait for the Publish Release Action to complete, and then check the latest release to ensure that the ZIP has been attached as an asset. Download the ZIP and inspect the contents to be sure they match the contents of the stable branch.
  • Close milestone: Edit the milestone with release date (in the Due date (optional) field) and link to GitHub release (in the Description field), then close the milestone.
  • Punt incomplete items: If any open issues or PRs which were milestoned for X.Y.Z do not make it into the release, update their milestone to X.Y.Z+1, X.Y+1.0, X+1.0.0, or Future Release.

@jeffpaul jeffpaul self-assigned this Sep 14, 2023
@jeffpaul jeffpaul added this to the 2.0.1 milestone Sep 14, 2023
@jeffpaul
Copy link
Member

@peterwilsoncc @dkotter not certain if we similarly need to version bump to 2.0.1 in

|| version_compare( $request->get_header( 'X-Distributor-Version' ), '2.0.0', '<' )
&&
|| version_compare( $response_headers['x-distributor-version'], '2.0.0', '<' )
or if that was only needed for 2.0.0 (e.g. for folks crossing the v1 to v2 divide)?

@jeffpaul
Copy link
Member

@dkotter @peterwilsoncc @ravinderk open to any of the following items currently in the 2.0.1 milestone getting wrapped up, merged, and included in the release:

But come Monday, we'll want to continue with the 2.0.1 in any case to get the fix out for the distributed author issue (and other updates in the release).

@ravinderk
Copy link
Contributor

@jeffpaul I started work on #1073. I will wrap it up by the end of next week.

@peterwilsoncc
Copy link
Collaborator

if that was only needed for 2.0.0 (e.g. for folks crossing the v1 to v2 divide)?

Only needed for crossing the divide so no need to bump.

@jeffpaul jeffpaul marked this pull request as ready for review September 19, 2023 01:44
@jeffpaul jeffpaul requested a review from a team as a code owner September 19, 2023 01:44
@jeffpaul jeffpaul requested review from iamdharmesh, peterwilsoncc and dkotter and removed request for a team September 19, 2023 01:44
@jeffpaul jeffpaul removed the request for review from peterwilsoncc September 19, 2023 01:45
CHANGELOG.md Outdated Show resolved Hide resolved
peterwilsoncc
peterwilsoncc previously approved these changes Sep 19, 2023
Copy link
Collaborator

@peterwilsoncc peterwilsoncc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I've just merged in a minor markdown fix so tests will need to rerun.

Copy link
Member

@iamdharmesh iamdharmesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@peterwilsoncc peterwilsoncc merged commit bf35374 into develop Sep 19, 2023
17 checks passed
@peterwilsoncc peterwilsoncc deleted the release/2.0.1 branch September 19, 2023 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants