Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Unable to PUSH new CPTs #528

Merged
merged 2 commits into from
Apr 10, 2020
Merged

Docs: Unable to PUSH new CPTs #528

merged 2 commits into from
Apr 10, 2020

Conversation

dinhtungdu
Copy link
Contributor

@dinhtungdu dinhtungdu commented Feb 19, 2020 •
edited
Loading

Description of the Change

Add new Know issues section about unable to push new CPTs.

Alternate Designs

See #366 (comment), #366 (comment) and #366 (comment)

Benefits

Cover one more issue.

Possible Drawbacks

n/a

Verification Process

Manual verification.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

Closes #366

Changelog Entry

@dinhtungdu dinhtungdu self-assigned this Feb 19, 2020
@jeffpaul jeffpaul added this to the 2.0.0 milestone Feb 19, 2020
@jeffpaul jeffpaul added the needs:documentation This requires documentation. label Feb 19, 2020
jeffpaul
jeffpaul approved these changes Feb 19, 2020
View reviewed changes
Copy link
Member

@jeffpaul jeffpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a couple tweaks to how we describe what's needed, but this is great... thanks for getting this covered @dinhtungdu!

@dkotter dkotter merged commit 4eb84a0 into develop Apr 10, 2020
@dkotter dkotter deleted the docs/366-push-to-new-cpts branch April 10, 2020 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffpaul jeffpaul jeffpaul approved these changes

Assignees

@dinhtungdu dinhtungdu

Labels
needs:documentation This requires documentation.
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.

Unable to PUSH new CPTs
3 participants
@dinhtungdu @jeffpaul @dkotter