Add proper error <ul>
so errors can be properly shown
#803
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
In our templates that output the connection dropdown, used when Pushing content, we were missing an unordered list element that we look for when outputting error messages. It appears this accidentally got removed when changes were made to better support AMP.
Without this element, if an error occurs during pushing, that error message will not be shown and a console error will happen (as reported in #795). This PR fixes this by adding that error element back to each template that needs it.
Alternate Designs
None
Benefits
Error messages will properly show and no console errors will happen
Possible Drawbacks
None
Verification Process
Easy way to create an error during push is to modify the
ajax_push
function and at the top of that, temporarily add awp_send_json_error
. Then go and try pushing some content. An error message should show and it should match whatever message as manually added.Checklist:
Applicable Issues
Closes #795
Changelog Entry