Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create dependency-review.yml #869

Merged
merged 1 commit into from
Apr 7, 2022
Merged

Create dependency-review.yml #869

merged 1 commit into from
Apr 7, 2022

Conversation

jeffpaul
Copy link
Member

@jeffpaul jeffpaul commented Apr 7, 2022

Description of the Change

Adds a dependency review action that scans all PRs for introducing insecure dependencies and will block merge of those PRs until the insecure item is resolved. Will help protect us from accidentally introducing insecure code into our projects. More details on this official GitHub Action here: https://github.blog/changelog/2022-04-06-github-action-for-dependency-review-enforcement/.

Alternate Designs

Don't have this and just... 🤞🏼?

Possible Drawbacks

none identified

Verification Process

No real way to test this besides get it running and see who has to buy everyone coffee at the next 10up Summit for being the first person to accidentally introduce an insecure dependency in a PR.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Changelog Entry

Added - Dependency security scanning.

Credits

n/a

@jeffpaul jeffpaul added this to the 1.7.0 milestone Apr 7, 2022
@jeffpaul jeffpaul requested a review from a team April 7, 2022 14:00
@jeffpaul jeffpaul self-assigned this Apr 7, 2022
@jeffpaul jeffpaul requested review from dkotter and removed request for a team April 7, 2022 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants