Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update from CONTRIBUTORS.md to CREDITS.md format #46

Merged
merged 3 commits into from
Nov 20, 2019
Merged

Conversation

jeffpaul
Copy link
Member

Description of the Change

Updates the handling of credit management to our CREDITS.md format.

Alternate Designs

keep as-is

Benefits

Follows the standard set in our Open Source Best Practices.

Possible Drawbacks

none identified

Verification Process

Manually verified via GitHub web UI.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

n/a

@jeffpaul jeffpaul added the needs:documentation This requires documentation. label Nov 13, 2019
@jeffpaul jeffpaul added this to the 1.1.1 milestone Nov 13, 2019
@jeffpaul jeffpaul self-assigned this Nov 13, 2019
@jeffpaul jeffpaul marked this pull request as ready for review November 13, 2019 20:17
ryanwelcher
ryanwelcher previously approved these changes Nov 20, 2019
Copy link

@ryanwelcher ryanwelcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeffpaul this looks good to me. We should add me to the list of maintainers though.

@jeffpaul jeffpaul merged commit db31730 into develop Nov 20, 2019
@jeffpaul jeffpaul deleted the update/credits branch September 30, 2020 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:documentation This requires documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants