Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insecure warnings are not displaying when I used CMD+S shortcut #53

Closed
Sidsector9 opened this issue Aug 4, 2021 · 2 comments · Fixed by #56
Closed

Insecure warnings are not displaying when I used CMD+S shortcut #53

Sidsector9 opened this issue Aug 4, 2021 · 2 comments · Fixed by #56
Assignees
Labels
type:enhancement New feature or request.
Milestone

Comments

@Sidsector9
Copy link
Member

Is your enhancement related to a problem? Please describe.
We currently listen for direct clicks on the publish button to know when to run our checks. This means the shortcut will never fire anything from us. We would either need to add this or refactor our save listener to be more inline with how Gutenberg works (like listening for isSavingPost)

Additional links

Link to the thread can be found here.

@Sidsector9 Sidsector9 added the type:enhancement New feature or request. label Aug 4, 2021
@Sidsector9 Sidsector9 added this to the 1.1.0 milestone Aug 4, 2021
@jeffpaul jeffpaul modified the milestones: 1.1.0, 1.0.0 Aug 16, 2021
@jeffpaul jeffpaul modified the milestones: 1.0.0, 1.1.0 Aug 24, 2021
@jeffpaul
Copy link
Member

Not viewing this as a blocker for v1 launch so punting to 1.1.0 so the v1 release can proceed.

@helen
Copy link
Contributor

helen commented Aug 24, 2021

Just to leave a comment to summarize discussion - it surprises me that GB fully updates a post with the keyboard shortcut instead of doing an autosave, probably because of my habits from the classic editor. I am having a hard time finding the decision being made for the block editor - we can double check to see if that's on purpose but I wouldn't be aiming to change it on that front at this point. Definitely seems like rethinking the save listener is the correct route.

@jeffpaul jeffpaul modified the milestones: 1.1.0, Future Release Oct 12, 2021
@jeffpaul jeffpaul moved this to In Progress in Open Source Practice Oct 12, 2021
@jeffpaul jeffpaul moved this from In Progress to To Do in Open Source Practice Oct 12, 2021
@jeffpaul jeffpaul moved this from To Do to In Progress in Open Source Practice Oct 12, 2021
@github-project-automation github-project-automation bot moved this from In Progress to Merged in Open Source Practice Aug 10, 2023
@jeffpaul jeffpaul modified the milestones: Future Release, 1.2.0 Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement New feature or request.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants