Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure compatibility with WordPress 5.9 #64

Merged
merged 3 commits into from
Jan 31, 2022
Merged

Ensure compatibility with WordPress 5.9 #64

merged 3 commits into from
Jan 31, 2022

Conversation

dkotter
Copy link
Collaborator

@dkotter dkotter commented Jan 27, 2022

Description of the Change

There was a reported issue with WP 5.9 where the Fix button was not working. This PR fixes this by updating the wp.data method we use to update the editor's content when using the block editor, as this method wasn't working in 5.9 anymore.

Also noticed a console error due to a missing key in our insecure asset list we output so fixed that as well.

We say we support down to WP 5.2 but in testing, things don't work on WP 5.2 but do work on WP 5.3+ (there is a minor styling issue with the Fix button in 5.3 and some console errors in 5.8 but everything seems to work).

Closes #63

Alternate Designs

None

Possible Drawbacks

None

Verification Process

Follow the steps listed on #63

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Changelog Entry

Fixed - Ensure we support WP 5.9

Credits

Props @dkotter, @mohitwp

@dkotter dkotter self-assigned this Jan 27, 2022
@jeffpaul jeffpaul requested review from a team and peterwilsoncc and removed request for a team January 28, 2022 14:33
@jeffpaul jeffpaul added this to the 1.1.0 milestone Jan 28, 2022
Copy link
Contributor

@peterwilsoncc peterwilsoncc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, tested in block editor locally successfully.

Should INSECURE_CONTENT_VERSION and the plugin version be updated here or is that done as part of the merge to the production branch?

@jeffpaul
Copy link
Member

@peterwilsoncc the version bumps happen during the release process, more on that here: https://github.com/10up/insecure-content-warning/blob/develop/CONTRIBUTING.md#release-instructions

@jeffpaul jeffpaul merged commit ecbf120 into develop Jan 31, 2022
@jeffpaul jeffpaul deleted the fix/wp-5.9 branch January 31, 2022 19:29
@jeffpaul jeffpaul mentioned this pull request Feb 15, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5.9 Compatibility issue > Fix is not working and user is not able to publish page or post.
3 participants