Skip to content
This repository has been archived by the owner on May 2, 2022. It is now read-only.

Removed :root wrapping around media queries #112

Merged
merged 1 commit into from
Jul 14, 2020
Merged

Removed :root wrapping around media queries #112

merged 1 commit into from
Jul 14, 2020

Conversation

jaredrethman
Copy link
Contributor

Description of the Change

Fixes issue described/suggested here - #111

Benefits

Will allow compiling of CSS media queries.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Changelog Entry

Fix to allow media queries to compile.

@jaredrethman jaredrethman marked this pull request as ready for review March 13, 2020 20:15
@jaredrethman jaredrethman mentioned this pull request Mar 13, 2020
Open
@samikeijonen
Copy link
Contributor

samikeijonen commented Mar 16, 2020 •
edited
Loading

Looks good to me, tested quickly with one @media(--bp-tiny).

@timwright12 timwright12 merged commit d7a8b18 into 10up:master Jul 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timwright12 timwright12 Awaiting requested review from timwright12

Assignees

@jaredrethman jaredrethman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaredrethman @samikeijonen @timwright12