Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to crop images before setting as avatar #65

Closed
jeffpaul opened this issue Nov 9, 2020 · 3 comments · Fixed by #83
Closed

Add ability to crop images before setting as avatar #65

jeffpaul opened this issue Nov 9, 2020 · 3 comments · Fixed by #83
Assignees
Labels
help wanted type:enhancement New feature or request.
Milestone

Comments

@jeffpaul
Copy link
Member

jeffpaul commented Nov 9, 2020

Is your enhancement related to a problem? Please describe.
Originally reported on WordPress.org support forum:

I’ve used this plugin foe a few years and love it. One feature I do miss is the ability to crop the avatars myself. Often the automatic crop just doesn’t look great, so I’ll have to do it myself on my PC and re-upload.

Alternatively, I could set a custom media size and use a different plugin to crop the images, if it’d be possible to point the avatar to use that size.

(Also, I ditto the other suggestion in this forum about making it easier to move domains with the plugin. I’m about to move my website and didn’t realize it’d mean I’d have to start from scratch with my user avatars…)

Thank you for this plugin!

Describe the solution you'd like
Follow the core flow of supporting crop when selecting an image for an avatar.

Designs
n/a

Describe alternatives you've considered
none

Additional context
n/a

@jeffpaul jeffpaul added the type:enhancement New feature or request. label Nov 9, 2020
@jeffpaul jeffpaul added this to the Future Release milestone Nov 9, 2020
@helen
Copy link
Contributor

helen commented Mar 11, 2021

I have no idea how the core crop workflow works with headers and icons but sure, seems reasonable to try to reuse that :)

@ajmaurya99
Copy link

Hey @helen @jeffpaul

I am not sure what is the correct approach for making the crop feature work, but I have tried to implement the image crop feature following this stack overflow thread - https://wordpress.stackexchange.com/questions/281760/using-media-uploader-to-select-image-of-specific-size-enforce-cropper/302962#302962

WIP Feature - https://share.getcloudapp.com/eDuR5Qjo [This is still not the correct way to do it]

Also, can't we just use the native WP crop feature something like this - https://share.getcloudapp.com/5zuNLZAp
This wont require any change at our end.

@helen
Copy link
Contributor

helen commented Sep 3, 2021

The user should be guided through the crop process - it is okay to me to have it be in the media modal, but it needs to be square only and enforce cropping after selection even if it's already a square image. The site icon in the customizer works this way and seems mostly ideal to me, or any number of avatar uploads around the web can serve as inspiration.

@jeffpaul jeffpaul linked a pull request Sep 9, 2021 that will close this issue
6 tasks
@ajmaurya99 ajmaurya99 mentioned this issue Sep 29, 2021
6 tasks
@jeffpaul jeffpaul modified the milestones: Future Release, 2.3.0 Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted type:enhancement New feature or request.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants