PHP 8 compatibility #103
Merged
PHP 8 compatibility #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix - Variable assignment found within a condition. Did you mean to do a comparison?
…quivalent of "false" for wp_enqueue_script; This means that the WordPress core version will be used which is not recommended for plugin or theme development.
…Security sections in the WordPress Developer Handbooks), found
| | 'get_simple_local_avatar'.
…o a comparison? + unused var
…Security sections in the WordPress Developer Handbooks), found `get_simple_local_avatar`.
…Security sections in the WordPress Developer Handbooks), found `get_simple_local_avatar` another.
faisal-alvi
requested review from
a team and
dkotter
and removed request for
a team
Sidsector9
requested changes
Mar 28, 2022
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| php: [ '5.6', '7.0', '7.4', '8.0', '8.1' ] |
There was a problem hiding this comment.
You can remove this matrix here and from the places where it is used. See this Slack post for more details.
Sidsector9
requested changes
Mar 28, 2022
| with: | ||
| php-version: '7.2' | ||
| coverage: none | ||
| tools: prestissimo, composer:v2 |
There was a problem hiding this comment.
prestissimo is unnecessary if we're using composer v2,
Refer to this for more details.
Sidsector9
requested changes
Mar 28, 2022
.github/workflows/lint.yml
Outdated
| - name: Check PHPCS standard | ||
| run: ./vendor/bin/phpcs -i | ||
| - name: PHPCS check | ||
| uses: chekalsky/phpcs-action@v1 |
There was a problem hiding this comment.
We're already using 10up/phpcs-composer in the project. Would be great to keep tools consistent.
Refer to this section for more details.
|
@Sidsector9 just a reminder, this is ready for review. |
Sidsector9
approved these changes
Apr 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Upgrade the plugin to be compatible with the least supportive PHP v5.3 up to the PHP v8.1
Verification Process
Make sure the Github actions are passing. Also, test the full plugin functionalities.
Checklist:
Changelog Entry
Credits
Props @faisal-alvi @dkotter @Sidsector9