Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add compatibility with plugins to upload images to Cloud storage (Azure Storage, AWS S3) #14

Merged
merged 7 commits into from
Oct 23, 2018
Merged

Conversation

eflorea
Copy link
Contributor

@eflorea eflorea commented Sep 13, 2018

use media_handle_upload instead of wp_handle_upload, update plugin version

use media_handle_upload instead of wp_handle_upload, update plugin ve…
…into 10up-develop

# Conflicts:
#	simple-local-avatars.php
use media_handle_upload instead of wp_handle_upload, update plugin version
@helen
Copy link
Contributor

helen commented Sep 14, 2018

I pushed a commit to revert out the whitespace changes so we can evaluate what's really changed here and for a cleaner history. Now that I am looking at the actual changes - I think this means that non-privileged users who upload avatars are now creating attachments rather than just having some files floating around the upload directory. What does that end up meaning for the "author" of the attachment (i.e. does having an otherwise non-privileged user assigned as the author of that attachment have any side effects), and does this potentially create a bunch of clutter in the media library? I guess on the upside you can now much more easily delete a bunch of avatars at once without having to go into each individual profile or FTP in (though the reference will still remain in user meta) but looking at the avatar_delete() method, those attachments won't get deleted later whereas the current way of uploaded non-attachments do get deleted ("unlink"-ed).

@helen helen mentioned this pull request Oct 19, 2018
@helen helen merged commit 6d72be6 into 10up:develop Oct 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants