Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Cancel edit mode #86

Merged
merged 7 commits into from
Jun 15, 2020

Conversation

Firestorm980
Copy link
Contributor

Description of the Change

Adds the ability for the user to edit their podcasting selection without going into the current "editor" mode and losing their currently selected podcast.

Alternate Designs

Using a custom toggle with the current editor mode and a "cancel" button.

Benefits

  • Allows the user to edit their media selection without losing their current selection if they decide to cancel
  • Aligns with the same editing pattern as the core audio block for consistency with WP core

Possible Drawbacks

May be initially confusing if a user/editor is used to the current paradigm of editing.

Verification Process

  1. Create a new podcast block
  2. Add a media file
  3. Click the "Replace" dropdown
  4. Click "Media Library" to replace file, abort
  5. Confirm the media wasn't replaced
  6. Click "Media Library", replace file
  7. Confirm the file was replaced

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

#62

Changelog Entry

Removed

  • Editing mode

Added

  • Core MediaReplaceFlow to edit the podcast media

@Firestorm980 Firestorm980 marked this pull request as ready for review April 17, 2020 19:01
@jeffpaul jeffpaul requested a review from dinhtungdu May 6, 2020 22:36
@jeffpaul jeffpaul added this to the 1.1.2 milestone May 6, 2020
@jeffpaul jeffpaul added the type:enhancement New feature or request. label May 6, 2020
Copy link
Contributor

@dinhtungdu dinhtungdu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Firestorm980 the replacement is a great UX enhancement, it worked perfectly in my test.

There is a small issue on deleting the podcast block, the podcast meta still remains in the post meta table.

@Firestorm980
Copy link
Contributor Author

There is a small issue on deleting the podcast block, the podcast meta still remains in the post meta table.

@dinhtungdu I tried deleting a block locally on the develop branch (not this feature) and confirmed none of the meta was removed (caption, duration, filesize, etc.) from the post. So it seems unrelated to this specific feature. I think it may be better to potentially make a new issue for this.

@jeffpaul
Copy link
Member

jeffpaul commented Jun 5, 2020

@Firestorm980 there are a couple merge conflicts after merging in your separate PR. Mind helping resolve the conflicts here so we can get this merged in?

@Firestorm980
Copy link
Contributor Author

@jeffpaul Updated. Should be good to go.

@jeffpaul jeffpaul merged commit 50b2cab into 10up:develop Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement New feature or request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants