-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Cancel edit mode #86
Feature: Cancel edit mode #86
Conversation
- add "cancel" and message
- minor fixes for react errors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Firestorm980 the replacement is a great UX enhancement, it worked perfectly in my test.
There is a small issue on deleting the podcast block, the podcast meta still remains in the post meta table.
@dinhtungdu I tried deleting a block locally on the |
@Firestorm980 there are a couple merge conflicts after merging in your separate PR. Mind helping resolve the conflicts here so we can get this merged in? |
@jeffpaul Updated. Should be good to go. |
Description of the Change
Adds the ability for the user to edit their podcasting selection without going into the current "editor" mode and losing their currently selected podcast.
Alternate Designs
Using a custom toggle with the current editor mode and a "cancel" button.
Benefits
Possible Drawbacks
May be initially confusing if a user/editor is used to the current paradigm of editing.
Verification Process
Checklist:
Applicable Issues
#62
Changelog Entry
Removed
Added
MediaReplaceFlow
to edit the podcast media