Update all npm

[jaredrethman]

Description of the Change

• Updated all NPM dependencies.
• CleanWebpackPlugin named export change. Requiring destructing at assignment in latest update.
• Added module and process to .eslint globals.
• Replaced .babel runtime config with bable.config.js.
• These updates will require a minimum of Node v8.11:
  • This has been added to the README.md
  • Added .npmrc to enforce engine-strict. engineStrict via package.json property is deprecated and un-enforceable.
• Added local property to testing.urls in package.json, resolving an error when running npm run test:a11y locally.

Alternate Designs

N/A

Benefits

• House keeping.
• Lines the code base up for usage of most stable packages in future enhancements. For example:
  • Webpack Dev Server & Hot Module Replacement.
  • Jest & Enzyme unit testing.
• Fixed 2 x bugs.
• Replaced .babelrc with babel.config.js:
  • Will compile node_modules/ - https://babeljs.io/docs/en/configuration#whats-your-use-case.
  • "The main benefit being that users can include JS logic to build up their config structures..."
  • "JS configs are great because they can compute a config on the fly"
  • Up to date with Babel Usage Guide.
  • Support more complex configurations.
• Force engineStrict|engine-strict Node version requirements.
• npm run test:a11y can now be run locally.

Possible Drawbacks

• NPM updates are on predominantly minor and patch versions. For package updates within major version updates, there are no breaking changes that would effect this code base (see below for list of these packages, and links, where possible, to release notes outlining breaking changes).

Verification Process

• Have tested all npm run * commands from package.json
• Have tested transpilation of ES6 to ES5; Array.prototype.reduce(), Array.prototype.reduceRight(), Array.prototype.includes(), String.prototype.includes(), Array.prototype.map(), Template literals (Template strings), Promise and Spread Syntax. This working as expected, and can be tested with this snippet, which will produce the below output in the console, and transpile to this.

• I was able to verify through running all commands, and ensured the command line stayed free from any warnings/errors.

• .npmrc to enforce engineStrict. engineStrict property via package.json is deprecated, since NPM 3.

Checklist:

• I have read the CONTRIBUTING document.
• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my change.
• All new and existing tests passed.

Applicable Issues

Style Lint:

Not an issue to this update, but applicable to why stylelint package, and associated packages, haven't been updated.

• Below is the current list of outdated packages. The current stylelint* config, is the only configuration, which produces no warnings/errors.

• The below warning has been resolved.

Major version changes:

• eslint: v5 to v6
  https://github.com/eslint/eslint/releases?after=v6.0.0
• eslint-loader: v2 to v3
  https://github.com/webpack-contrib/eslint-loader/releases/tag/v3.0.0
• babel-eslint: v9 to v10
  https://github.com/babel/babel-eslint/releases/tag/v10.0.0
• clean-webpack-plugin: v2 to v3
  https://github.com/johnagan/clean-webpack-plugin/releases/tag/v3.0.0
• lint-staged: v8 to v9
  https://github.com/okonet/lint-staged/releases?after=v9.2.0
• postcss-preset-env: v5 to v6
  https://github.com/csstools/postcss-preset-env/releases
• stylelint-config-wordpress: v13 to v14
  https://github.com/WordPress-Coding-Standards/stylelint-config-wordpress/releases
• stylelint-order: v1 to v2
  https://github.com/hudochenkov/stylelint-order/releases
• terser: v3 to v4
  https://github.com/terser/terser/blob/master/CHANGELOG.md#v400
• webpackbar: v3 to v4
  https://github.com/nuxt/webpackbar/blob/master/CHANGELOG.md#400-2019-08-05

Changelog Entry

• Updated all npm packages.
• Added local property to testing.urls in package.json, resolving an error when running npm run test:a11y locally.
• Replaced .babelrc with babel.config.js
• Updated CleanWebpackPlugin variable assignment, requiring destructing in the newer version.
• Added .npmrc to enforce engineStrict

Associated Plugin Scaffold PR - 10up/plugin-scaffold#102

[timwright12]

@jaredrethman can you add these to the plugin repo as well? Also, what's the benefit you see of moving babelrc?

[jaredrethman]

@timwright12

can you add these to the plugin repo as well?

Definitely, I'll get on that asap.

what's the benefit you see of moving .babelrc

1.) Primary motivation: Babel >= 7 recommends babel.config.js over .babelrc. Future proofing.
2.) We can perform logical operations before deciding which presets/plugins to use i.e. NODE_ENV - #149

More here - https://babeljs.io/docs/en/config-files

[jaredrethman]

@timwright12 have added this Code Review equivalent to the Plugin Scaffold - 10up/plugin-scaffold#102 and updated this pull.

[timwright12]

@jaredrethman looks like some conflicts popped up.

We'll need these updates for the plugin as well 10up/plugin-scaffold#102

One last note for Added module and process to .eslint globals. -- I don't see those in the updates in the .eslintrc file

[tylercherpak]

@timwright12 given the nature of these changes, I think we should try to get them merged posthaste since it is very likely that these types of merge conflicts will keep coming up.

[jaredrethman]

Hey @timwright12 ,

I have resolved those conflicts, updated 10up/plugin-scaffold#102 and added module & process to eslint global whitelist.

[timwright12]

@jaredrethman looks good, just confirming the plugin repo before merge