Replace LiveReload with Browsersync #66
Conversation
|
@colorful-tones does this PR replace #65 ? |
|
@colorful-tones once this PR is worked out, we need to get the changes into the plugin repo before merging as well |
|
@JodiWarren For the local URL issue... would using https://superuser.com/questions/949428/whats-the-difference-between-127-0-0-1-and-0-0-0-0 |
|
@garand Normally If you want to quickly test this, try on the command line: In the (nearish) future we're going to have a FWIW this is just being provided to the |
Yes, this replaces #65
👍 that makes sense and will make sure to push it through to that repo once we're happy with final implementation in I'm still trying to get out best way to wrap a check for |
Trying to get too fancy. 🤦
truly was BS :-p
Fancy != Better
gulpfile.babel.js
Outdated
| if ( proxyUrl ) { | ||
| // https://browsersync.io/docs/options | ||
| bs.init({ | ||
| proxy: packproxyUrl, |
There was a problem hiding this comment.
Hey, I think you've got a wee typo on packproxyUrl
There was a problem hiding this comment.
Mate if that's the worst bug you make in a PR you're doing well.
and get some sleep!
|
I opened an Issue on the Plugin Scaffold so we can get this in there once we're satisfied with results here. |
|
@colorful-tones This is good to go, let's get it into the plugin scaffold and I'll merge at the same time. |
|
@timwright12 PR is in on Plugin Scaffold now: 10up/plugin-scaffold#58 Thanks. |
I've just taken what @JodiWarren has done in #65 and updated README.md and used the URL in
package.jsonCloses #60