Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WordPress tested version #66

Merged
merged 4 commits into from
Apr 29, 2024
Merged

Update WordPress tested version #66

merged 4 commits into from
Apr 29, 2024

Conversation

oscarssanchezz
Copy link
Contributor

Description of the Change

This PR updates the WordPress tested up to version, and also bumps the tested NewRelic agent.

Closes #61

How to test the Change

n/a

Changelog Entry

n/a

Credits

n/a

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@jeffpaul jeffpaul added this to the 1.4.0 milestone Apr 29, 2024
readme.txt Outdated
Requires at least: 4.0
Tested up to: 6.3
Requires at least: 6.3
Tested up to: 6.5.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For future reference, you can leave the major version here (e.g. 6.5) and WP.org will update to show the current minor as the tested-up-to version.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jeffpaul , I've updated this here: 5d1c7bb

@@ -16,7 +16,7 @@

## Overview

WP New Relic (WPNR) is designed to be used with the [New Relic APM](https://newrelic.com/application-monitoring), and uses the [New Relic PHP Agent API](https://docs.newrelic.com/docs/agents/php-agent/configuration/php-agent-api) to augment existing metrics with valuable WordPress details such as templates, users, request type, and [Transaction](https://docs.newrelic.com/docs/apm/transactions) names. This plugin is tested with New Relic's PHP Agent version 6.7.0.174. Data collected by this plugin can be queried in [New Relic's Insights](https://newrelic.com/insights/) product, using [New Relic Query Language (NRQL)](https://docs.newrelic.com/docs/insights/new-relic-insights/using-new-relic-query-language/nrql-reference).
WP New Relic (WPNR) is designed to be used with the [New Relic APM](https://newrelic.com/application-monitoring), and uses the [New Relic PHP Agent API](https://docs.newrelic.com/docs/agents/php-agent/configuration/php-agent-api) to augment existing metrics with valuable WordPress details such as templates, users, request type, and [Transaction](https://docs.newrelic.com/docs/apm/transactions) names. This plugin is tested with New Relic's PHP Agent version 10.19.0.9. Data collected by this plugin can be queried in [New Relic's Insights](https://newrelic.com/insights/) product, using [New Relic Query Language (NRQL)](https://docs.newrelic.com/docs/insights/new-relic-insights/using-new-relic-query-language/nrql-reference).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should a similar reference exist in readme.txt to render on WP.org? should this be defined somewhere in the code as well?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jeffpaul I've added a section in readme.txt to note the latest version we have tested here 9bfd656

readme.txt Outdated
Requires at least: 4.0
Tested up to: 6.3
Requires at least: 6.3
Tested up to: 6.5.2
Stable tag: 1.3.2
Requires PHP: 7.3.11
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we bump to 7.4 or 8.0 here as well?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated this here: 5d1c7bb

jeffpaul
jeffpaul previously approved these changes Apr 29, 2024
Copy link
Member

@jeffpaul jeffpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some questions/comments, but otherwise looks fine for merge

@jeffpaul jeffpaul merged commit f5e0adf into develop Apr 29, 2024
1 check passed
@jeffpaul jeffpaul deleted the tested-up-tp/6.5.2 branch April 29, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The plugin hasn't been tested with the latest version of WordPress
4 participants