Fix typos #250
Merged
Fix typos #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmolham-godaddy
requested changes
Jul 24, 2024
There was a problem hiding this comment.
Thanks @szepeviktor for fixing these typos, I have one suggestion below
| @@ -90,7 +90,7 @@ public function iExpectWhenIRunWithArgs( $return, $function, TableNode $args ) { | |||
| /** | |||
| * @Then I expect :return when I run :function | |||
| */ | |||
| public function iExcpectWhenIRun( $return, $function ) { | |||
| public function iExpectWhenIRun( $return, $function ) { | |||
There was a problem hiding this comment.
Did you fully check the implications of renaming this method? I know it is a typo, but it is considered code change, what do you think about defining a new alias method to it, and marking this one as deprecated? ex:
/**
* @Then I expect :return when I run :function
*
* @deprected use static::iExpectWhenIRun instead
*/
public function iExcpectWhenIRun( $return, $function ) {
static::iExpectWhenIRun( $return, $function )
}
/**
* @Then I expect :return when I run :function
*/
public function iExpectWhenIRun( $return, $function ) {
$this->iExpectWhenIRunWithArgs( $return, $function, new TableNode( array( array() ) ) );
}There was a problem hiding this comment.
Done.
TBH I treat everything as text when I fix typos.
There was a problem hiding this comment.
No worries, it happens, thanks for the fixes
There was a problem hiding this comment.
Glad to contribute.
nmolham-godaddy
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Found misspellings in docs and in function name.
Contributor checklist
Testing
Reviewer checklist