Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new flag: EXTRA_ARGS to support custom arguments #12

Merged
merged 8 commits into from
May 18, 2022

Conversation

dinhtungdu
Copy link

@dinhtungdu dinhtungdu commented May 15, 2022

Description of the Change

This PR adds a new flag to support custom arguments. Originally, I hard-coded to generate a JSON file for job summary, but I think an extra argument is better because it lets users enable the JSON report generation only if they want to display the summary.

Closes #

Alternate Designs

Possible Drawbacks

Verification Process

See 10up/maps-block-apple#128 and https://github.com/10up/maps-block-apple/actions/runs/2326290393

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Changelog Entry

Added EXTRA_ARGS allows users to add custom arguments to the phpcs command.

Credits

Props @dinhtungdu

@dinhtungdu dinhtungdu requested review from a team and cadic and removed request for a team May 15, 2022 07:26
@dinhtungdu dinhtungdu merged commit c200834 into develop May 18, 2022
@dinhtungdu dinhtungdu deleted the try/gh-actions-summary branch May 18, 2022 02:05
@jeffpaul jeffpaul modified the milestones: 1.4.0, 1.3.4 Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants