Install the VIPCS package from a specific branch #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkotter
requested review from
peterwilsoncc
and removed request for
a team and
peterwilsoncc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
We currently install the VIPCS package from the main branch, which means we're always pulling in the latest changes. They recently made some major changes to go along with the 3.0.0 release of the WPCS package and this breaks things with how we currently install these packages.
Similar to the change in #34, this PR fixes things by installing a specific branch of the VIPCS package. This allows things to run properly again, though same as noted in #34, we should look to refactor how we install these packages to use composer instead, to ensure we can use the latest versions of things (so this fix should be looked at as temporary).
How to test the Change
Can see that with this change in place, issues are properly flagged in ClassifAI
Changelog Entry
Credits
Props @dkotter, @TylerB24890
Checklist: