add the support of multi coverage file for the baseline command + rai… #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ses an error when the custom coverage can be increased
…ses an error when the custom coverage can be increased
…ses an error when the custom coverage can be increased
frankdekker
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a previous feature, we added the support for multiple coverage files to the inspect command.
Though this change wasn't also made for the baseline command which is now making it very difficult to generate the baselines when the coverage is split in multiple files.
Also, in an attempt to keep our baselines clean and up-to-date, so we can have a better overview, I've changed the behavior when the coverage doesn't match the custom coverage set in the baseline. Previously an error was raised only if the coverage was below the custom coverage in the baseline, it is also now raising an error when the coverage is above the custom coverage in the baseline.