jQuery 3 compatibility #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok, will look into it :) |
1337
requested changes
Apr 23, 2018
jquery.viewport.js
Outdated
| @@ -114,7 +114,7 @@ | |||
| return true; | |||
| } | |||
|
|
|||
| $.extend($.expr[':'], { | |||
| $.extend($.expr.pseudos, { | |||
There was a problem hiding this comment.
This breaks jQuery 1.5.x, which is fine because the package doesn't say which version of jQuery it supports, but as an easy way to ignore it, would you mind changing this to $.expr.pseudos || $.expr[':']?
|
Dear Brian, thanks for your quick response. I just added the requested amendment for supporting jQuery 1.5.x to this PR. Thanks a bunch for spotting this! Cheers, |
|
Thank you @amotl :) |
|
Thank you very much for the handling of this little update and for pushing it out to the npm.js package repository so quickly! For all others finding this, the package is located at https://www.npmjs.com/package/jquery.viewport. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear Brian,
this little amendment makes
jquery.viewportready for jQuery 3.3.1, following the standardization of the custom pseudo object. Can we humbly ask you to push a 1.0.1 release to npmjs.com?With kind regards,
Andreas.