Upgrade #3
Closed
Upgrade #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: CodeLingo Bot <bot@codelingo.io>
Add a CallerPrettyfier callback to the json formatter
…formatter Add a CallerPrettyfier callback to the text formatter
Example caller prettyfier
Fix race getcaller
Fix error formatting based on best practices from Code Review Comments
Add WithContext
Add CHANGELOG for v1.4.0
Test with Go 1.12
Drop x/crypto package dependency
remove go1.11.x from travis build matrix
run golangci-lint on travis
remove obsolete documentation
Creates a copy of the data map when using WithContext to create a child entity. Without this, the data map of the parent entitiy, which is exposed in the entity struct, is shared between a parent and all children instances. This can create bugs of shared or overwritten data when a parent entity is used to make children in differing contexts, and behaves differently than `WithField` and its diritivites which does make a copy of the data. Additionally implements the same logic for WithTime, for API consistency in behavior.
Clarifies the data used in the EntryWithContextCopiesData test and adds an equivalent test to verify the behavior of WithTime.
…ibility. One entry in the Logrus formatters list in the readme contained a lot of extraneous punctuation. When read with a screen reader, nothing but a bunch of question marks and weird symbol names could be heard, making the line impossible to understand.
Remove annoying punctuation in Readme for better screen reader accesssibility
…sEntities Fix entry data bleed when using WithContext and WithTime
Add hook to send logs to custom writer sirupsen#678
Only mark issues as stale for now until we go through backlog of PRs
Fix typos in docs for New()
…entry fix race conditions on entry
add caption-json-formatter
improve Logger.WithField documentation
Rewrite if-else-if-else to switch statements
Fix caller package name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.