Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analytics logging in edge-case scenarios #138

Closed
GUI opened this issue Oct 30, 2014 · 1 comment
Closed

Analytics logging in edge-case scenarios #138

GUI opened this issue Oct 30, 2014 · 1 comment

Comments

@GUI
Copy link
Member

GUI commented Oct 30, 2014

If a request to an API backend times out (after 60 seconds by default), the entries in the analytics system for those requests seem to be missing the details on the api_key and user of the requester.

@GUI GUI added the bug label Oct 30, 2014
@GUI GUI changed the title User and api key details missing from analytics on requests that timeout Analytics logging in edge-case scenarios Nov 6, 2014
@GUI
Copy link
Member Author

GUI commented Nov 6, 2014

(Renaming this issue to be broader and inclusive of the issues we've also seen in #106)

As a quick update on this issue, I've been working on a bit of an overhaul in how we coalesce our analytics data on API requests. The new approach simplifies the code, ensures we log things properly in a variety of edge-case scenarios where we're missing data, and also makes it much easier to recover the analytics if something goes terribly wrong and the system can't perform it's logging temporarily. It's also faster, more efficient, and gets the analytics into the system more quickly. More integration tests have also been added to test these various edge-case scenarios.

So all-in-all, I think this analytics update is shaping up nicely and will bring more sanity to one of the odder bits of code in the system. I just need to complete some load testing and do some more checks, and then I think we can schedule this for an upcoming update to the platform.

The code is currently sitting in the beanstalk-logs branches of the gatekeeper and router.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant