Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete initial single method page #271

Closed
wants to merge 1 commit into from
Closed

Complete initial single method page #271

wants to merge 1 commit into from

Conversation

echappen
Copy link
Contributor

@echappen echappen commented Dec 15, 2023

Changes proposed in this pull request:

  • Completes layout for single method page—example on /methods/discover/cognitive-walkthrough
  • Also fixes some duplicate package warnings in package.json

known issues

  • We add link icons by evaluating markdown before it’s compiled into html. This doesn’t account for data-based html that doesn’t come from markdown, which is why some headers/links get the icon and others don’t. We should have a system that accounts for the compiled resulting html instead of the markdown, but I consider this outside the scope of this issue (I'll make an issue for it).
  • We're using the same USWDS version and theme settings sitewide. Since the old Methods site uses USWDS v2x and this repo uses 3x, there will be slight differences in font size, spacing, etc.

Closes #228

security considerations

None

@echappen echappen requested a review from a team as a code owner December 15, 2023 21:19
@echappen echappen requested review from jduss4 and removed request for a team December 15, 2023 21:20
@echappen
Copy link
Contributor Author

closing in favor of #273

@echappen echappen closed this Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build single card page for Methods site
1 participant