Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proof of concept for single card and multi-card pages #273

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Conversation

echappen
Copy link
Contributor

Changes proposed in this pull request:

  • Completes layout for single card page—example on /methods/discover/cognitive-walkthrough
  • Completes layout for multi-card page—example on /methods/discover
  • Also fixes some duplicate package warnings in package.json
  • Proof of concept only—remaining content will be done in Port over all remaining content for Methods site #234

Known issues

  • We add link icons by evaluating markdown before it’s compiled into html. This doesn’t account for data-based html that doesn’t come from markdown, which is why some headers/links get the icon and others don’t. We should have a system that accounts for the compiled resulting html instead of the markdown, but I consider this outside the scope of this issue (I'll make an issue for it).
  • We're using the same USWDS version and theme settings site-wide. Since the old Methods site uses USWDS v2x and this repo uses 3x, there will be slight differences in font size, spacing, etc.

Closes #228
Closes #229

security considerations

None

@echappen echappen requested a review from a team as a code owner December 18, 2023 16:54
@echappen echappen requested review from jduss4 and removed request for a team December 18, 2023 16:54
Copy link
Contributor

@jduss4 jduss4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple questions, but they aren't blockers so I went ahead and approved!

_includes/methods/print-header.html Show resolved Hide resolved
assets/methods/img/printer.png Show resolved Hide resolved
@echappen echappen merged commit b62b3a6 into main Dec 18, 2023
13 checks passed
@echappen echappen deleted the eoc/229 branch December 18, 2023 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build multi-card page for Methods site Build single card page for Methods site
2 participants