Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve consistency of dropdowns with USWDS, other fields #263

Merged
merged 1 commit into from
Oct 25, 2021

Conversation

aduth
Copy link
Member

@aduth aduth commented Oct 22, 2021

Why: Backports styling from brochure site (example), and makes it so that form fields share common background and border styling, and inherits more from USWDS (specifically the arrow graphic).

Live preview URL: https://federalist-2f194a10-945e-4413-be01-46ca6dae5358.app.cloud.gov/preview/18f/identity-style-guide/aduth-select-arrows/components/form-fields/#dropdowns

Before After
before after

**Why**: Backports styling from brochure site, and makes it so that form fields share common background and border styling, and inherits more from USWDS (specifically the arrow graphic).
@aduth aduth requested a review from nickttng October 22, 2021 15:10
Copy link
Member

@nickttng nickttng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preview looks good to me. 👍🏼

Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aduth
Copy link
Member Author

aduth commented Oct 25, 2021

Visual regression diff is expected:

image

@aduth aduth merged commit 5703a67 into main Oct 25, 2021
@aduth aduth deleted the aduth-select-arrows branch October 25, 2021 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants