Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve consistency of dropdowns with USWDS, other fields #263

Merged
merged 1 commit into from
Oct 25, 2021
Merged

Improve consistency of dropdowns with USWDS, other fields #263

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@
- Add Login.gov-specific component configuration. ([#258])(https://github.com/18F/identity-style-guide/pull/258)
- [Identifier component](https://designsystem.digital.gov/components/identifier/)
- Link colors on dark backgrounds
- Overlay: Updated visual appearance. ([#260](https://github.com/18F/identity-style-guide/pull/260))
- Overlay is now shown with a lighter backdrop color. ([#260](https://github.com/18F/identity-style-guide/pull/260))
- Form Dropdown is now more visually consistent with other form fields. ([#263](https://github.com/18F/identity-style-guide/pull/260))
- Form hint text is now shown with an italicized style and increased vertical margins. ([#262](https://github.com/18F/identity-style-guide/pull/262))

## 6.2.0
Expand Down
11 changes: 0 additions & 11 deletions src/img/arrow-down-filled.svg
View file
Open in desktop

This file was deleted.

21 changes: 2 additions & 19 deletions src/scss/components/_inputs.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@ $checkbox-radio-size: .875rem;
$input-select-margin-right: 1;

.usa-input,
.usa-textarea {
.usa-textarea,
.usa-select {
@include u-border-color('primary-light');
font-weight: font-weight('bold');
background-color: color('primary-lightest');
Expand All @@ -39,24 +40,6 @@ $input-select-margin-right: 1;
border-top-right-radius: 0;
}

.usa-select {
@include u-border-color('primary-light');
@include add-background-svg('arrow-down-filled');
font-weight: font-weight('bold');
background-position: right .75rem center;
background-size: units(1);
border-radius: radius('md');

&:focus {
@include disable-default-focus-styles;
box-shadow: roundable-focus-outline-box-shadows();
}

&.usa-input--error {
@include u-border-color('error');
}
}

.usa-label {
font-weight: font-weight('bold');
}
Expand Down