Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace stylelint-config-recommended-scss with stylelint-config-standard #10564

Merged
merged 5 commits into from
May 7, 2024

Conversation

aduth
Copy link
Member

@aduth aduth commented May 7, 2024

🎫 Ticket

Partially addresses #10545 (cc @anselmbradford)

🛠 Summary of changes

Updates Stylelint configuration to extend stylelint-config-standard-scss instead of stylelint-config-recommended-scss.

See CHANGELOG.md for more information:

This also moves "reportNeedlessDisables": true from our project-specific configuration into the shared configuration. This will report inline configuration that disables rules unnecessarily, which is already enforced within this project.

📜 Testing Plan

Verify yarn lint:css passes.

aduth added 5 commits May 7, 2024 11:45
…ard-scss

changelog: Internal, Build Tools, Replace stylelint-config-recommended-scss with stylelint-config-standard-scss
Due to Sass incompatibilities

See: sass/sass#2831
@aduth aduth force-pushed the aduth-stylelint-standard-config branch from 5dd4a75 to c5b09bc Compare May 7, 2024 15:45
@aduth aduth merged commit 94e38cb into main May 7, 2024
2 checks passed
@aduth aduth deleted the aduth-stylelint-standard-config branch May 7, 2024 16:43
@aduth
Copy link
Member Author

aduth commented May 7, 2024

Published beta tag to NPM as @18f/identity-stylelint-config@5.0.0-beta.1

https://www.npmjs.com/package/@18f/identity-stylelint-config?activeTab=versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants