Remove unnecessary allowed_extra_analytics #10776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changelog: Internal, Automated Testing, Sync exemptions for allowed extra analytics
brandemix
pushed a commit
to brandemix/18F-identity-idp
that referenced
this pull request
Jun 17, 2024
* Remove all exemptions changelog: Internal, Automated Testing, Sync exemptions for allowed extra analytics * Revert failing files * Revert failing files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Removes unnecessary
alowed_extra_analyticsin spec files.Follows #10740 and #10749 as these are unnecessary but not consistently caught by our
allowed_extra_analyticschecker.The approach here was to remove all
alowed_extra_analytics, run a full build, and then reset files tomainwhere failures continue to exist.📜 Testing Plan
Verify build passes.