Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup platform authentication #5632

Merged
merged 1 commit into from
Dec 15, 2021
Merged

Setup platform authentication #5632

merged 1 commit into from
Dec 15, 2021

Conversation

jmhooper
Copy link
Member

Why: So that people can use their platform authenticator devices to access login.gov

@jmhooper
Copy link
Member Author

This is very WIP, but I wanted to get it up so folks could see where this is going!

@aduth

This comment has been minimized.

Sign in to view
aduth added a commit that referenced this pull request Nov 29, 2021
@aduth @zachmargolis
Use platform_authenticator parameter for ivar
4ce3b97 
https: //github.com//pull/5632/files#r755568160
Co-Authored-By: Zach Margolis <zbmargolis@gmail.com>
@juliaelman

This comment has been minimized.

Sign in to view
aduth
aduth reviewed Dec 7, 2021
View reviewed changes
.erb-lint.yml Outdated Show resolved Hide resolved
@juliaelman juliaelman marked this pull request as ready for review December 7, 2021 23:20
juliaelman pushed a commit that referenced this pull request Dec 8, 2021
@aduth @zachmargolis
Use platform_authenticator parameter for ivar
80ec738 
https: //github.com//pull/5632/files#r755568160
Co-Authored-By: Zach Margolis <zbmargolis@gmail.com>
@juliaelman
Copy link
Member

In this iteration, are we planning to include a link from the account page to set up a platform authenticator on an existing account?

@aduth re-thinking this. For UAT in the lower env (see addition of feature flag), I don't think we should add platform auth to the account management profile. I also like the idea of creating a down stream PR to create less of a monolith of a PR for folks to review, commit to. Going to spin up a new PR for that!

@aduth
Copy link
Member

aduth commented Dec 8, 2021

@aduth re-thinking this. For UAT in the lower env (see addition of feature flag), I don't think we should add platform auth to the account management profile. I also like the idea of creating a down stream PR to create less of a monolith of a PR for folks to review, commit to. Going to spin up a new PR for that!

Makes sense 👍

aduth
aduth reviewed Dec 9, 2021
View reviewed changes
config/locales/account/en.yml Outdated Show resolved Hide resolved
@mitchellhenke
Copy link
Contributor

One thing that I'm not sure about at a high level is the separation/naming of the two. They share some things like a database table and bits of behavior, but there are parts that are pretty distinct in the experience and interface. Right now, most of the naming for cross platform authenticators is webauthn and the platform authenticators get _platform appended.

Do we want to consider renaming webauthn to something like webauthn_cross_platform or webauthn_roaming to be less ambiguous?

@mitchellhenke mitchellhenke force-pushed the platform-auth branch 2 times, most recently from 941fce2 to cf99e61 Compare December 9, 2021 16:34
juliaelman pushed a commit that referenced this pull request Dec 14, 2021
@aduth @zachmargolis
Use platform_authenticator parameter for ivar
ba57309 
https: //github.com//pull/5632/files#r755568160
Co-Authored-By: Zach Margolis <zbmargolis@gmail.com>
@mitchellhenke mitchellhenke mentioned this pull request Dec 14, 2021
Merged
@mitchellhenke mitchellhenke force-pushed the platform-auth branch 2 times, most recently from 5aac793 to 5b99c06 Compare December 15, 2021 18:06
aduth
aduth approved these changes Dec 15, 2021
View reviewed changes
Copy link
Member

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

spec/controllers/users/two_factor_authentication_controller_spec.rb Outdated Show resolved Hide resolved
@jmhooper
Setup platform authentication
83caf3d 
Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
Co-authored-by: Jonathan Hooper <jonathan.hooper@gsa.gov>
Co-authored-by: Mitchell Henke <mitchell.henke@gsa.gov>

**Why**: So that people can use their platform authenticator devices to access login.gov
@juliaelman juliaelman merged commit ac47b4f into main Dec 15, 2021
@juliaelman juliaelman deleted the platform-auth branch December 15, 2021 18:28
nathanberg added a commit that referenced this pull request Dec 16, 2021
@nathanberg
Merge branch 'main' into nathanberg-error-add-linter
aeb597c 
* main: (50 commits)
  LG-5325 Doc Auth: Error dependent hints and enhanced field level errors (#5708)
  Setup platform authentication (#5632)
  Remove unused i18n keys by replacing dynamic key generation with static enumeration (#5706)
  Configure and fix Rubocop redundant disabling/enabling (#5711)
  LG-4575: accessiblility issue where no file selected still shows after adding file.  (#5691)
  Update rails to 6.1.4.3 (#5710)
  Add remote SAML Logout endpoint (#5676)
  Update "Frontend" CSS docs to reflect current approach (#5695)
  LG-3795 Harden CSP against JSONP endpoints on "safe" domains (#5704)
  LG-5261: Add cancel page logging to "Go Back" button (#5697)
  Add flow path to post doc capture submission events (LG-5257) (#5690)
  Log all vendor status in VendorStatus#track_event (#5703)
  Remove accept-terms-button in favor of ValidatedFieldComponent (#5687)
  Upgrade as many outdated Ruby dependencies as possible (LG-3828) (#5694)
  Remove BassCSS flex-object styling (#5702)
  Remove unused personal-key pattern validation message (#5701)
  Smoke tests in GitLab CI (#5699)
  Show a message in lower envs explaining how to use test SSNs (#5696)
  Remove temporary routes for SP redirects (#5679)
  LG-5262: Add logging to continue button on letter wait page (#5688)
  ...
jmhooper added a commit that referenced this pull request Dec 28, 2021
@jmhooper
Setup platform authentication (#5632)
c738fe2 
Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
Co-authored-by: Jonathan Hooper <jonathan.hooper@gsa.gov>
Co-authored-by: Julia Elman <julia.elman@gsa.gov>
Co-authored-by: Mitchell Henke <mitchell.henke@gsa.gov>

**Why**: So that people can use their platform authenticator devices to access login.gov
@mitchellhenke mitchellhenke mentioned this pull request Jan 6, 2022
Closed
@aduth aduth mentioned this pull request Aug 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliaelman juliaelman juliaelman left review comments

@zachmargolis zachmargolis zachmargolis left review comments

@aduth aduth aduth approved these changes

@mitchellhenke mitchellhenke mitchellhenke approved these changes

Assignees
No one assigned
Labels
status - ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jmhooper @aduth @juliaelman @mitchellhenke @zachmargolis