feat: add optional parameters to OpenAIEmbeddingModel for enhanced embedding functionality #4129
+64
−51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
shaohuzhang1
commented
Sep 28, 2025
apps/models_provider/impl/openai_model_provider/model/embedding.py
Outdated
Show resolved
Hide resolved
liuruibin
force-pushed
the
pr@v2@feat_embedding_params
branch
from
d1fc866 to
da39129
Compare
shaohuzhang1
commented
Sep 28, 2025
liuruibin
force-pushed
the
pr@v2@feat_embedding_params
branch
from
da39129 to
b7268ce
Compare
shaohuzhang1
commented
Sep 28, 2025
apps/models_provider/impl/aliyun_bai_lian_model_provider/model/embedding.py
Show resolved
Hide resolved
shaohuzhang1
commented
Sep 28, 2025
…bedding functionality
liuruibin
force-pushed
the
pr@v2@feat_embedding_params
branch
from
b7268ce to
ae2e08d
Compare
shaohuzhang1
commented
Sep 28, 2025
apps/models_provider/impl/aliyun_bai_lian_model_provider/model/embedding.py
Show resolved
Hide resolved
shaohuzhang1
commented
Sep 28, 2025
apps/models_provider/impl/aliyun_bai_lian_model_provider/credential/embedding.py
Show resolved
Hide resolved
shaohuzhang1
commented
Sep 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: add optional parameters to OpenAIEmbeddingModel for enhanced embedding functionality