Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve support for item categories #52

Open
AlexHoffmann opened this issue Dec 10, 2021 · 2 comments
Open

Improve support for item categories #52

AlexHoffmann opened this issue Dec 10, 2021 · 2 comments
Labels
tracked Issue is tracked in 1Password's internal ticketing system as well.

Comments

@AlexHoffmann
Copy link

We've received this bit of feedback from a customer:

1Password Terraform does not support any other item categories apart from Login, Password and Database.

At the moment we utilise AWS Secret Manager where you are able to store a flat JSON object without any compulsory fields. Utilising any of the supported item categories in 1password provider forces us to have compulsory fields such as "password" "url" "username" which are different with supported item categories.

We could definitely use, for instance Password item category with only one compulsory field "password", and just add custom fields as required. But in the future we would have to migrate to appropriate item categories once you add support to the provider causing additional overhead.

So the questions are: Is there a roadmap to add more categories to Terraform provider? If so when and which ones? Particularly categories without any compulsory field? Although I'm not sure if 1password has categories like that. And/or can you think of any workarounds with available categories without compulsory fields? Although kind of new, but there's already an issue reported on your Github #51 regarding missing document category

The team in Slack mentioned that this is a know issue and a workaround that was offered, e.g. using the API credentials category was shot down again because there seems to be an issue retrieving API credentials via the Terraform provider.

Someone from our team added in Slack:

I hit this personally recently. Unfortunately some weird things happen with the current terraform provider release and api credentials (I couldn’t access the credential)
There was talking in April/May of improving and expanding the supported Item types but I don’t think anything materialized there

@edif2008 edif2008 added the tracked Issue is tracked in 1Password's internal ticketing system as well. label May 30, 2022
@Twister42
Copy link

Yes this definitely need a fix, when using "API Credential" in 1Password the main keys are username and credential.
The Terraform provider only give access to username and password.
I had to copy credential in a password fiel in all my "API Credential" entries used by Terraform, it's (more than) a bit annoying.

@devin-8flow
Copy link

It's $current_year and we still can't fetch API credentials from terraform without first duplicating the field into password. :/

SMillerDev added a commit to SMillerDev/terraform-provider-onepassword that referenced this issue May 27, 2024
SMillerDev added a commit to SMillerDev/terraform-provider-onepassword that referenced this issue Jun 11, 2024
volodymyrZotov added a commit that referenced this issue Jun 17, 2024
* feat: add credential to item datasource

Issue GH-52

* feat: add credential to item datasource

Issue GH-52

* Remove 'credential' type from the data-source

* Remove 'credential' type from the resource docs

---------

Co-authored-by: Volodymyr Zotov <volodymyr.zotov@agilebits.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tracked Issue is tracked in 1Password's internal ticketing system as well.
Projects
None yet
Development

No branches or pull requests

4 participants