Add temporal_route end-date #6664
Conversation
|
What is the issue now? |
|
I can see this log, but what does it mean? TEST KazooTests\Applications\Crossbar\SystemConfigConferencesSection (testDefaultApplied) ... ERROR 0.01s too_many_requests Fatal error: Uncaught Kazoo\Api\Exception\RateLimit: too_many_requests in /home/user/make-busy/vendor/2600hz/kazoo-php-sdk/lib/hz2600/Kazoo/HttpClient/HttpClient.php:94 |
|
When this PR will be merged? |
| @@ -29,6 +29,12 @@ | |||
| "description": "Whether the rule is enabled", | |||
| "type": "boolean" | |||
| }, | |||
| "end_date": { | |||
| "default": 0, | |||
There was a problem hiding this comment.
Generally, we prefer that the absence of the value would mean no end date. Remove the default; end_date should only have a value if it is a proper, meaningful timestamp.
| "end_date": { | ||
| "default": 0, | ||
| "description": "The date that the rule ends. Zero means no end date", | ||
| "support_level": "supported", |
There was a problem hiding this comment.
support_level is a 2600Hz-only field to include, please remove.
| @@ -51,6 +52,7 @@ | |||
| ,ordinal = ?RULE_DEFAULT_ORDINAL :: ordinal() | |||
| ,month = ?RULE_DEFAULT_MONTH :: kz_time:month() | |||
| ,start_date = ?RULE_DEFAULT_START_DATE :: kz_time:date() | |||
| ,end_date = ?RULE_DEFAULT_END_DATE :: kz_time:date() | |||
There was a problem hiding this comment.
Should default to 'undefined' instead of the tuple. Type would be kz_time:date() | 'undefined'
| -spec check_end_date(non_neg_integer(), kz_term:ne_binary(), kz_time:datetime(), integer(), kzd_temporal_rules:doc()) -> 'future' | 'equal' | 'past'. | ||
| check_end_date(LSec, TZ, Now, EndDateSeconds, RulesDoc) -> | ||
| % TODO, this is an workaround since the from_gregorian_seconds function are crashing on low values such as zero | ||
| case EndDateSeconds of |
There was a problem hiding this comment.
Check the value for 'undefined' instead of 0, and I would do it in a function clause:
check_end_date(_LSec, _TZ, _Now, 'undefined', _RulesDoc) -> 'future';
check_end_date(...) ->
I've recreated the PR since there was some issue with the git unstaged files