Fell back to using the enum values in the field choices if the UI labels are not set
#1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…abels are not set Was also forced to drop ability to set custom field choices because it wouldn't be possible to "deconstruct" the field (without a major rework of the field) -- Plus, I couldn't see how this feature would actually be useful. CIT-162
3 similar comments
The previous commit introduced an inconsistency when the enum didn't have UI labels (the key was the enum value). CIT-162
2 similar comments
franciscoruiz
approved these changes
Apr 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was also forced to drop ability to set custom field choices because it wouldn't be possible to "deconstruct" the field (without a major rework of the field) -- Plus, I couldn't see how this feature would actually be useful.
CIT-162