Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use auto assigned port for InnerServer #61

Merged
merged 1 commit into from
Aug 3, 2015
Merged

Use auto assigned port for InnerServer #61

merged 1 commit into from
Aug 3, 2015

Conversation

NickAb
Copy link
Contributor

@NickAb NickAb commented Aug 3, 2015

Closes #39

skyline-gleb
skyline-gleb reviewed Aug 3, 2015
View reviewed changes
Winium/Winium.StoreApps.Common/ConnectionInformation.cs
{
#region Public Properties

public const string FileName = ".Winium.StoreApps.ConnectionInformation.json";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

предлагаю FileNameSuffix вместо FileName, это и вернее и просто предпочитаю помечать так

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Почему суффикс? Это прям имя файла, к нему больше ничего не добавляется.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

а точка вначале меня и смутила. а зачем она?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Да можно и без неё. Это с всяких nix'овых вещей, где точка в начале файла означала скрытый файл, например: .gitignore, .dockerignore, .vagrantfile. А здесь она чтобы сразу было ясно, что это какой-то "системный" файл для Winium, это позволит легко отделить этот файл от остальных при просмотре в IsoStoreSpy например.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

пусть остается, я думаю

@skyline-gleb
Copy link
Contributor

поле Winium.StoreApps.InnerServer.AutomationServer.listeningPort забылось удалиться

skyline-gleb added a commit that referenced this pull request Aug 3, 2015
@skyline-gleb
Merge pull request #61 from 2gis/dynamic-innerport
01effa5 
Use auto assigned port for InnerServer
@skyline-gleb skyline-gleb merged commit 01effa5 into master Aug 3, 2015
@skyline-gleb skyline-gleb deleted the dynamic-innerport branch August 3, 2015 07:24
@bayandin bayandin mentioned this pull request Oct 3, 2016
Merged
NickAb pushed a commit to 2gis/winphonedriver that referenced this pull request Oct 4, 2016
@bayandin @NickAb
Use auto assigned port for InnerServer
5975a11 
Backport 2gis/Winium.Mobile#61
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NickAb @skyline-gleb