Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only show content types where 1 or more template is available #1614

Closed
rf-999 opened this issue Aug 28, 2018 · 4 comments
Closed

Only show content types where 1 or more template is available #1614

rf-999 opened this issue Aug 28, 2018 · 4 comments
Assignees

Comments

@rf-999
Copy link

rf-999 commented Aug 28, 2018

I'm submitting a ...
[x] bug report

...about
[x] edit experience / UI
[x] admin experience UI

Current behavior / Minimal reproduction

  1. insert new 2sxc Content Module ("Content")
  2. the list of available content types shows up, it includes all content types, even if there isn't an available template to select. Clicking on such a content type leads to a dead end (confusing) and makes the content type list unnecessarily long.

Expected behavior
2. the list of available content types only includes content types which have one or more templates to select.

What is the motivation / use case for changing the behavior?
make sure that the content type list is as short as possible, and that admin only sees relevant content types. Make sure that hiding templates also hides the whole content type in selection.
In 2sxc v8 this was implemented, but got lost somewhere in 2sxc 9.x

Because of this, I marked this as a bug report and not as a feature request.

  • 2sxc version(s): 9.32.1
  • Browser: [all]
  • DNN: [all | 7.4.2]
  • Language: [any/all]

Anything you would like to add
it wouldn't be that critical if there would be a more clear indicator that there are another content types hidden at the right side. The vertical toolbar which appears is IMO not enough "discoverable" as a standalone indicator.
more-indicator-ct-select

Probably even better: make sure that there is no need to scroll, i.e. by using flex to dynamically shrink the items to match with the viewport size (just a thought)

@iJungleboy
Copy link
Contributor

I tried to reproduce by adding a type which doesn't have templates - but it didn't show up. I believe your scenario is more complex or has something I don't know. Could @reto-f-999 Elaborate or send me a link with an example?

@rf-999
Copy link
Author

rf-999 commented Nov 6, 2018

ok - sent you a direct mail with repro example.

iJungleboy added a commit to 2sic/2sxc-ui that referenced this issue Feb 15, 2019
@iJungleboy iJungleboy self-assigned this Feb 15, 2019
@iJungleboy
Copy link
Contributor

found and fixed

@cassidi-peterson
Copy link

Did this bug creep back in in version 14? Showing all content types even without any views.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants