Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean-html by using a less intrusive toolbar in the html: sxc-toolbar and @Edit.TagToolbar #1685

Closed
5 of 7 tasks
iJungleboy opened this issue Feb 21, 2019 · 0 comments
Closed
5 of 7 tasks
Assignees

Comments

@iJungleboy
Copy link
Contributor

iJungleboy commented Feb 21, 2019

I'm submitting a ...
[x] feature request

...about
[x] edit experience / UI
[x] Razor templating
[x] 2sxc-inpage

Current behavior
Currently toolbars place an <ul> tag in the html (which is then parsed by javascript) and in addition usually need an sc-element class to aid positioning. This has various imperfections, incl.

  1. end-user html includes helper classes like sc-element which are simply not usefull, and might cause the web-designer to start programming against that
  2. in edit-mode, the html actually has stuff in it, which is different from read-mode
  3. the tags have some styles overriding other behavior

Expected behavior
A perfect solution would only add something to the output, if the user really is in edit mode, and would ideally leave the html and css-positioning of the page itself unmodified.

What is the motivation / use case for changing the behavior?
Perfection :)

Steps to implement

  • define new convention for placing toolbar data in an attribute of a tag - probably sxc-toolbar
  • define a new convention for the data format
  • define a new convention for "attaching" the toolbar to the item, not using a css-class but using a attribute like sxc-toolbar-hover
  • modify the client-side 2sxc-inpage to support this
  • ensure that the previous implementation using sc-element still works, or is transformed to the new version
  • create server-side helper commands on @Edit.TagToolbar to implement this.
  • ensure positioningn etc. works flawlesly

Please tell us about your environment:

  • 2sxc version(s): 9.35
@iJungleboy iJungleboy self-assigned this Feb 21, 2019
iJungleboy added a commit to 2sic/2sxc-inpage that referenced this issue Feb 24, 2019
iJungleboy added a commit to 2sic/2sxc-inpage that referenced this issue Feb 24, 2019
@iJungleboy iJungleboy changed the title Clean-html by using a less intrusive toolbar in the html Clean-html by using a less intrusive toolbar in the html: sxc-toolbar and @Edit.TagToolbar Mar 9, 2019
iJungleboy added a commit to 2sic/2sxc-eav-languages that referenced this issue Mar 9, 2019
iJungleboy added a commit that referenced this issue Mar 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant