Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential problem with installation on Windows when Git is on path #231

Closed
edwardsph opened this issue Oct 9, 2015 · 2 comments
Closed

Comments

@edwardsph
Copy link
Contributor

After installing Git in Windows I couldn't run the Callimachus setup script. It was complaining it couldn't find "#". On investigation I discovered that Git had put it's bin folder on the path ahead of the windows system folders so the script was using it's find which is not compatible. The solution was to prefix calls to find with "\Windows\System32" to force the correct one. Do you think this is something worth considering for all commands called from the scripts to make them less vulnerable to path problems?

@catch-point
Copy link
Contributor

I think windows have an environment variable that include the current path to the windows directory (some OEM installs use a different path). Prefixing the find commend with this windows path variable should be a portable solution to this.

@edwardsph
Copy link
Contributor Author

Good idea. I think the nearest we get is the Windows folder:
On my PC I have:
SystemRoot=C:\WINDOWS
windir=C:\WINDOWS
We may need to check further but we could use
%SystemRoot%\System32\find

Pete

On 9 October 2015 at 17:51, James Leigh notifications@github.com wrote:

I think windows have an environment variable that include the current path
to the windows directory (some OEM installs use a different path).
Prefixing the find commend with this windows path variable should be a
portable solution to this.


Reply to this email directly or view it on GitHub
#231 (comment)
.

edwardsph added a commit to edwardsph/callimachus that referenced this issue Feb 9, 2016
catch-point added a commit that referenced this issue Feb 10, 2016
Add warning related to #231 in the release notes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants