Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make dockerfile available #66

Closed
srinandan opened this issue Oct 20, 2016 · 3 comments
Closed

Make dockerfile available #66

srinandan opened this issue Oct 20, 2016 · 3 comments
Assignees

Comments

@srinandan
Copy link

When users deploy to shipyard, we create a dockerfile for their node.js application. I'd like to make that dockerfile available via an API or something. This will allow users to deploy and test their node.js application outside of the Apigee infra.

@noahdietz
Copy link
Contributor

@mpnally @jbowen93 @whitlockjc @AdamMagaluk thoughts?

The Dockerfile is available in the source code. This isn't ideal at all, i understand. Providing an API to access it seems kind of heavy weight, but would also make it easier to maintain compared to hosting it somewhere and updating it when kiln changes.

@mpnally
Copy link
Contributor

mpnally commented Oct 26, 2016

Making it a resource with a URL seems very simple to me. what made you say
heavyweight?

Martin

On Wed, Oct 26, 2016 at 2:13 PM, Noah Dietz notifications@github.com
wrote:

@mpnally https://github.com/mpnally @jbowen93
https://github.com/jbowen93 @whitlockjc https://github.com/whitlockjc
@AdamMagaluk https://github.com/AdamMagaluk thoughts?

The Dockerfile is available in the source code
https://github.com/30x/kiln/blob/master/pkg/kiln/io.go#L229-L243. This
isn't ideal at all, i understand. Providing an API to access it seems kind
of heavy weight, but would also make it easier to maintain compared to
hosting it somewhere and updating it when kiln changes.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#66 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ACoA6nd2lZOjDvuKLe6YkFeIbHsDcwZ0ks5q38J8gaJpZM4KcKDr
.

Martin Nally, Apigee Engineering

@noahdietz
Copy link
Contributor

noahdietz commented Oct 26, 2016

I think putting it somewhere other than kiln is the better solution. kiln's job isn't to supply Dockerfiles, its to build images. Adding a resource for this, imo, will add bloat. I think we should just host it in the repo separately in a resources directory for people to reference. Or anywhere else.

For example, the docker daemon (what kiln wraps) doesn't have an API that gives you the Dockerfile of the base image you request i.e. if i want to use mhart/alpine-node:latest, there is no way for me to see that through docker APIs, i have to go to GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants