Restore s3 #47
Merged
Restore s3 #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
'restore' might have been a better word choice than 'replace' |
|
replaced the test cases that were removed, passed test suite |
| @@ -12,6 +12,11 @@ import ( | |||
| "k8s.io/kubernetes/pkg/api" | |||
| ) | |||
|
|
|||
| const ( | |||
There was a problem hiding this comment.
These should be environment variables because these values are configurable at the k8s-router level so we should make them configurable here as well.
|
@tnine Do you mind reviewing this? The code looks fine but you're more familiar with the implementation than I. |
* validates any pod template spec posted to S3 for `routable` `publicPaths` and an internal image URI * add dev deployment file for quick in-cluster deving * add dev Makefile targets
|
@whitlockjc @noahdietz This looks GTM. Aside from the env var comment @whitlockjc made, everything looks solid in this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #48