Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PTS_URL host echoes request host #50

Merged
merged 1 commit into from
Aug 16, 2016
Merged

PTS_URL host echoes request host #50

merged 1 commit into from
Aug 16, 2016

Conversation

noahdietz
Copy link
Contributor

Fixes #49

  • removes SELF_BASE_URL environment variable
  • copies image build request hostname into resulting PTS_URL

@whitlockjc
Copy link
Contributor

LGTM as long as it was tested, there don't seem to be tests for this.

@noahdietz
Copy link
Contributor Author

noahdietz commented Aug 12, 2016 •
edited
Loading

@whitlockjc I hand tested it, but you're right there is not a unit test for this.

@noahdietz noahdietz merged commit e9085f4 into master Aug 16, 2016
@noahdietz noahdietz deleted the issue-49 branch August 16, 2016 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noahdietz @whitlockjc