Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove PTS URL & generation #78

Merged
merged 2 commits into from
Jan 24, 2017
Merged

remove PTS URL & generation #78

merged 2 commits into from
Jan 24, 2017

Conversation

noahdietz
Copy link
Contributor

fixes #76

  • removes PTS URL generation on application import
  • removes PTS generation APIs (accessed via a PTS URL)

noahdietz
noahdietz commented Jan 23, 2017
View reviewed changes
pkg/server/server.go
outputString := fmt.Sprintf(templateString, image.ImageID, server.generatePodSpecURL(dockerInfo, r.Host, createImage.PublicPath))

writeStringAndFlush(w, flusher, outputString)
writeStringAndFlush(w, flusher, "done")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No longer providing a PTS URL or image sha.

@noahdietz
Copy link
Contributor Author

@whitlockjc I've removed the podspec I/O that I had left in before. Review when ready.

@noahdietz noahdietz mentioned this pull request Jan 23, 2017
Closed
@whitlockjc
Copy link
Contributor

LGTM

@noahdietz noahdietz merged commit 4a578dc into master Jan 24, 2017
@noahdietz noahdietz deleted the issue-76 branch January 24, 2017 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

remove ptsUrl functionality
2 participants
@noahdietz @whitlockjc