kiln API refactor #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* adds support for variable base image based on runtime selection * fixes test cases (commented out ECS tests due to credential issues)
whitlockjc
reviewed
Jan 25, 2017
| func DetermineBaseImage(runtimeSelection string) (baseImage string, err error) { | ||
| runtimeSplit := strings.Split(runtimeSelection, ":") | ||
|
|
||
| switch runtimeSplit[0] { |
There was a problem hiding this comment.
Maybe we could turn this into a RuntimeMap or something where we map runtime values to a known base image?
There was a problem hiding this comment.
I had the same idea, to use a map to store the supported runtimes, but I wasn't sure how much more effective that would be than this given we would still need to manually update the map, and also possibly concat the base image with the desired version (i.e. node:4, node:5.1.2, java:7) as is done here. It is something to explore, and if my mental model is off-base or you had another perspective, let me know.
There was a problem hiding this comment.
I get you. I wouldn't map each {runtime}:{version}, just each {runtime} to a base image.
whitlockjc
reviewed
Jan 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #74
adds variable runtime selection through the parsing of a parameter into a corresponding supported base image. only node is currently supported
fix tests (commented out the ECS due to credential problems. will get resolved soon).