Switch to using char::encode_utf8 #132
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Rust 1.15, the function `char::encode_utf8` was stabilized. Assuming that rmp follows the serde standard of supporting the last 3 stable releases, this function is now safe to use. I believe this removes the last allocation required on the serialization path.
|
Great, thanks for the PR! AFAIK someone (@bluss at least) uses rmp-serde crate with 1.13. If it doesn't hurt anyone else, I'll merge this PR with major version bump. |
|
I can adapt. Major version for Rust version upgrades is the policy I've been using, but I can handle if this crate doesn't agree. Any recent changes in the conventional wisdom here? |
|
Manually rebased and merged: 5bbdbc7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Rust 1.15, the function
char::encode_utf8was stabilized. Assumingthat rmp follows the serde standard of supporting the last 3 stable
releases, this function is now safe to use. I believe this removes the
last allocation required on the serialization path.