Skip to content

Conversation

semtexzv
Copy link

@semtexzv semtexzv commented Jun 18, 2017

Hello, first PR :).
I had a problem with rmp-serde serializing structs as arrays so I added methods with _named suffix that would fix this. I also removed utlity methods from lib.rs and added reexports from encode.rs and decode.rs, since those methods were exactly same

Sorry for all the formatting spam.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 86.122% when pulling 69de5df on semtexzv:master into d78f3ee on 3Hren:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.7%) to 86.781% when pulling 69de5df on semtexzv:master into d78f3ee on 3Hren:master.

@3Hren
Copy link
Owner

3Hren commented Jun 19, 2017

Hi! Thanks for the contribution.

Could you please exclude all style-changing stuff from the PR? It's hard to figure out what was changed.

termoshtt added a commit to termoshtt/msgpack-rust that referenced this pull request Jul 22, 2017
@termoshtt
Copy link
Contributor

Good work. I need this PR.
I've remove formatting part at termoshtt#1
@semtexzv Could you check my branch and rebase to there?
Or, should I open another PR?

@hjiayz
Copy link

hjiayz commented Aug 1, 2017

good job

termoshtt added a commit to termoshtt/msgpack-rust that referenced this pull request Aug 2, 2017
@3Hren
Copy link
Owner

3Hren commented Aug 2, 2017

Merged in #140.

@3Hren 3Hren closed this Aug 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants