Skip to content

feat: Add as_ref() to Value and Utf8String #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 27, 2017
Merged

feat: Add as_ref() to Value and Utf8String #139

merged 1 commit into from
Jul 27, 2017

Conversation

rolag
Copy link
Contributor

@rolag rolag commented Jul 27, 2017

Since ValueRef has a to_owned() method, it makes sense for Value to have an as_ref() method.

@3Hren
Copy link
Owner

3Hren commented Jul 27, 2017

Hi! Thanks for the PR!

Looks good to me, waiting for travis ...

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 87.058% when pulling 428058c on rolag:master into 0756032 on 3Hren:master.

@3Hren 3Hren merged commit 1f5f21f into 3Hren:master Jul 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rolag @3Hren @coveralls