WIP - Support for encoding structs as maps #38
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it would be useful to support serializing structs as MessagePack maps in addition to the current method of serializing them as arrays. It appears that deserialization of structs in this form already works; I didn't note any explicit logic for this case in
decode.rs
so I assume serde is already handling it.I'm not crazy about the API I've exposed, this is just an initial proof of concept. If this feature is something you'd like to add, I'd be happy to discuss a better API and implementation.
It should be possible to support this feature without additional runtime branching or code duplication -- using generics. However, I think it would require a slightly different public API.
Thanks providing this great library.