Several serde deserialization fixes #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When decoding enums.
This commit also forbids the following Option deserialization cases: - Option<()>. - Option<Option<...>>. It's impossible to properly deserialize the listed cases without explicit option marker in protocol. If required I can consider injecting another policy in Deserializer. This commit fixes #41.
This was referenced Sep 9, 2015
This change allows to easily override default enum deserialization behavior. As an example there is enum deserialization without wrapping tuple of size 2.
3Hren
force-pushed
the
pr/fix-serde-enums
branch
from
bbb3555 to
46d0093
Compare
Previously it was serialized as unit (nil), now there is just empty array ([]).
- New error type introduced - UnknownLength. Returned on attempt to serialize struct, map or serquence with unknown length (Serde allows this). - The new type is returned if necessary. - Added unit test to check proper empty map serialization.
3Hren
force-pushed
the
pr/fix-serde-enums
branch
5 times, most recently
from
be6e818 to
632705c
Compare
3Hren
force-pushed
the
pr/fix-serde-enums
branch
from
632705c to
43f3ac3
Compare
3Hren
added a commit
that referenced
this pull request
Sep 10, 2015
Several serde deserialization fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optionwith default initialization (using unit).Add--features=serde_macrosto TravisCI.