misc(rmp): allow use of newer byteorder dep #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! However it's a common practice in Semantic Versioning to break the backward compatibility in minor releases until 1.0, so the only way for me is to test each minor release manually. But unfortunately due to lack of information about byteorder's backward compatibility between 0.3 and 0.4 just bumping rmp dependency results in undefined state of its own backward compatibility, which in turns results in minor version bumping (and for all its clients transitively). If you restrict the version to ^0.4 (meaning 0.4.*) I'll merge this PR in master branch, but wait some time until publishing. |
Right now byteorder 0.4.2 works fine without code changes. Switching to the newer versions allow users of this crate to avoid pulling in (unneededly) multiple versions of the same crate (byteorder uses libc, which is widely depended on)
|
I've modified this PR to restrict the version as requested. |
3Hren
added a commit
that referenced
this pull request
Jan 18, 2016
misc(rmp): allow use of newer byteorder dep
|
Great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now byteorder 0.4.2 appears to work fine without code changes.
And 0.3.x will (of course) continue to work.
We want to expand the allowed versions so users of this crate can avoid
pulling in (unneededly) multiple versions of the same create (byteorder
uses libc)
I've expanded the version match to allow any '0.*' version to avoid
repeating this commit in the future, but I'm OK if you'd like a more
restricted version (does cargo allow '<0.5 && >=0.3'?).