refactor(KtAvatar): composition api, tippy, scoped SCSS #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…so for KtAvatarGroup
…aking change by renaming prop names
Isokaeder
force-pushed
the
kt-avatar-group-refactor
branch
from
39f30ac
to
a5340ce
Compare
FlorianWendelborn
added
priority:3-normal
FlorianWendelborn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently clashes with #420.
In three different commits I:
It got big so I don't have a problem splitting it up if necessary
Also it seems
_tooltip.scssis obsolete now, as there are notooltipclasses around anymore